[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231101174422.zs5er6tqethm46ur@CAB-WSD-L081021>
Date: Wed, 1 Nov 2023 20:44:22 +0300
From: Dmitry Rokosov <ddrokosov@...utedevices.com>
To: Conor Dooley <conor@...nel.org>
CC: Rob Herring <robh@...nel.org>, <linux-leds@...r.kernel.org>,
<lee@...nel.org>, <linux-kernel@...r.kernel.org>,
<kernel@...rdevices.ru>, <andy.shevchenko@...il.com>,
<conor+dt@...nel.org>, <pavel@....cz>,
<krzysztof.kozlowski+dt@...aro.org>, <rockosov@...il.com>,
<robh+dt@...nel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 11/11] dt-bindings: leds: aw200xx: fix led pattern and
add reg constraints
Hello Conor,
On Wed, Nov 01, 2023 at 04:17:14PM +0000, Conor Dooley wrote:
> On Wed, Nov 01, 2023 at 11:04:16AM -0500, Rob Herring wrote:
> >
> > On Wed, 01 Nov 2023 17:24:45 +0300, Dmitry Rokosov wrote:
> > > AW200XX controllers have the capability to declare more than 0xf LEDs,
> > > therefore, it is necessary to accept LED names using an appropriate
> > > regex pattern.
> > >
> > > The register offsets can be adjusted within the specified range, with
> > > the maximum value corresponding to the highest number of LEDs that can
> > > be connected to the controller.
> > >
> > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx")
> > > Signed-off-by: Dmitry Rokosov <ddrokosov@...utedevices.com>
> > > ---
> > > .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++--
> > > 1 file changed, 58 insertions(+), 6 deletions(-)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@0: Unevaluated properties are not allowed ('reg' was unexpected)
> > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@1: Unevaluated properties are not allowed ('reg' was unexpected)
> > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@2: Unevaluated properties are not allowed ('reg' was unexpected)
> > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml#
>
> Looks like you need to drop the second part of this hunk from the patch.
> @@ -45,17 +45,12 @@ properties:
> maxItems: 1
>
> patternProperties:
> - "^led@[0-9a-f]$":
> + "^led@[0-9a-f]+$":
> type: object
> $ref: common.yaml#
> unevaluatedProperties: false
>
> properties:
> - reg:
> - description:
> - LED number
> - maxItems: 1
> -
> led-max-microamp:
> default: 9780
> description: |
>
> Each LED still only has one reg entry, right?
You're right... the maxItems for 'reg' is still needed. I'll back it in
the next version.
But I don't understand, why my dt_binding_check run doesn't show me this
problem... I don't specify DT_CHECKER_FLAGS, maybe this is a root cause.
--
Thank you,
Dmitry
Powered by blists - more mailing lists