lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <74c8dd58-f4b8-41fa-b5da-d4e32326ffd1@roeck-us.net>
Date:   Wed, 1 Nov 2023 14:03:12 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Nik Bune <n2h9z4@...il.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, robh@...nel.org,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        skhan@...uxfoundation.org, wim@...ux-watchdog.org
Subject: Re: [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to
 yaml

On 11/1/23 13:33, Nik Bune wrote:
> Changes in v2: updated commit message.
> 
> v1 patch: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231031201602.28827-1-n2h9z4@gmail.com/


Unfortunately, you didn't run checkpatch on your uudate, meaning it missed

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)

Indeed, your patch now provides a single-line commit description with more than
200 characters.

I don't think "Keep it in one line" was meant to ask you to do that.
The original description was substantially shorter and did fit into 75 characters.

Guenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ