linux-kernel - [paulmck-rcu:dev.2023.11.01a 18/37] kernel/locking/qspinlock.c:691:6: warning: no previous declaration for 'spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 2 Nov 2023 06:53:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: [paulmck-rcu:dev.2023.11.01a 18/37]
 kernel/locking/qspinlock.c:691:6: warning: no previous declaration for
 'spinlock_dump'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2023.11.01a
head:   a5d1576b5e4924bc6884b992be2345013a663c82
commit: 851f9c70733ed644c8a03d8f93f9876942181bee [18/37] EXP qspinlock: Add spinlock_dump() to dump lock state
config: i386-defconfig (https://download.01.org/0day-ci/archive/20231102/202311020612.oQucVrSC-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311020612.oQucVrSC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311020612.oQucVrSC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/locking/qspinlock.c:691:6: warning: no previous declaration for 'spinlock_dump' [-Wmissing-declarations]
    void spinlock_dump(spinlock_t *sp, bool full)
         ^~~~~~~~~~~~~


vim +/spinlock_dump +691 kernel/locking/qspinlock.c

   690	
 > 691	void spinlock_dump(spinlock_t *sp, bool full)
   692	{
   693		int cpu;
   694		int i = 0;
   695		int idx;
   696		struct mcs_spinlock *msp;
   697		struct qspinlock qval = sp->rlock.raw_lock;
   698	
   699		cpu = tail_to_cpu(qval.tail);
   700		idx = tail_to_idx(qval.tail);
   701		pr_alert("%s: %ps %#x (%c%c%c%c %#x: %d[%d]\n",
   702			 __func__, sp, (unsigned int)atomic_read(&qval.val),
   703			 ".L"[!!qval.locked],
   704			 ".P"[!!qval.pending],
   705			 ".Q"[cpu >= 0 && idx >= 0],
   706			 ".F"[!!full],
   707			 (unsigned int)qval.tail, cpu, idx);
   708		pr_alert("%s: _Q_TAIL_CPU_OFFSET=%d _Q_TAIL_IDX_MASK=%d _Q_TAIL_IDX_OFFSET=%d _Q_LOCKED_VAL=%d _Q_TAIL_OFFSET=%d sizeof(->tail)=%lu\n",
   709			__func__, _Q_TAIL_CPU_OFFSET, _Q_TAIL_IDX_MASK, _Q_TAIL_IDX_OFFSET, _Q_LOCKED_VAL, _Q_TAIL_OFFSET, (unsigned long)sizeof(qval.tail));
   710		if (!full || cpu < 0 || idx < 0)
   711			return;
   712		msp = per_cpu_ptr(&qnodes[idx].mcs, cpu);
   713		while (i++ < nr_cpu_ids && (msp = next_to_prev(msp, &cpu, &idx))) {
   714			pr_alert("%s: Q%d CPU %d[%d] %c%d\n", __func__, i, cpu, idx,
   715				 ".L"[!!msp->locked], msp->count);
   716		}
   717		if (i >= nr_cpu_ids && cpu >= 0 && idx >= 0)
   718			pr_alert("%s: Queue output truncated.\n", __func__);
   719		else
   720			pr_alert("%s: End of queue.\n", __func__);
   721	}
   722	EXPORT_SYMBOL(spinlock_dump);
   723	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki