linux-kernel - Re: [cocci] [PATCH 1/2] scripts: coccicheck: Return error from run_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <978265928.4471013.1698960475973.JavaMail.zimbra@inria.fr>
Date:   Thu, 2 Nov 2023 22:27:55 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Anton Eliasson <anton.eliasson@...s.com>
Cc:     nicolas palix <nicolas.palix@...g.fr>, cocci <cocci@...ia.fr>,
        linux-kernel <linux-kernel@...r.kernel.org>, kernel@...s.com
Subject: Re: [cocci] [PATCH 1/2] scripts: coccicheck: Return error from
 run_cmd_parmap



----- Mail original -----
> De: "Anton Eliasson" <anton.eliasson@...s.com>
> À: "Julia Lawall" <Julia.Lawall@...ia.fr>, "nicolas palix" <nicolas.palix@...g.fr>
> Cc: "cocci" <cocci@...ia.fr>, "linux-kernel" <linux-kernel@...r.kernel.org>, "Anton Eliasson" <anton.eliasson@...s.com>,
> kernel@...s.com
> Envoyé: Mardi 3 Octobre 2023 16:25:14
> Objet: [cocci] [PATCH 1/2] scripts: coccicheck: Return error from run_cmd_parmap

> Exiting on error breaks the chain mode. Return the error instead in
> order for the caller to propagate it or in the case of chain, try the
> next mode.
> 
> Signed-off-by: Anton Eliasson <anton.eliasson@...s.com>
> ---
> scripts/coccicheck | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index e52cb43fede6..95a312730e98 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -153,7 +153,7 @@ run_cmd_parmap() {
> 	err=$?
> 	if [[ $err -ne 0 ]]; then
> 		echo "coccicheck failed"
> -		exit $err
> +		return $err
> 	fi
> }
> 

I tried disabling OCaml in my version of Coccinelle and then ran make coccicheck with this patch.  But I didn't see any improvement.  On the other hand, it keeps going if I just remove the exit line entirely.  Is that what is wanted?  One can still see the coccicheck failed message.

julia

> --
> 2.30.2