linux-kernel - Re: [PATCH] mm/hugetlb: fix null ptr defer in hugetlb_vma_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202311030737.my9iglMI-lkp@intel.com>
Date:   Fri, 3 Nov 2023 07:29:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Edward Adam Davis <eadavis@...com>, riel@...riel.com
Cc:     oe-kbuild-all@...ts.linux.dev, akpm@...ux-foundation.org,
        eadavis@...com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        llvm@...ts.linux.dev, mike.kravetz@...cle.com,
        muchun.song@...ux.dev, nathan@...nel.org, ndesaulniers@...gle.com,
        syzbot+6ada951e7c0f7bc8a71e@...kaller.appspotmail.com,
        syzkaller-bugs@...glegroups.com, trix@...hat.com
Subject: Re: [PATCH] mm/hugetlb: fix null ptr defer in hugetlb_vma_lock_write

Hi Edward,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Edward-Adam-Davis/mm-hugetlb-fix-null-ptr-defer-in-hugetlb_vma_lock_write/20231103-003152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/tencent_164A247533766D667C3D873798968236C409%40qq.com
patch subject: [PATCH] mm/hugetlb: fix null ptr defer in hugetlb_vma_lock_write
config: um-defconfig (https://download.01.org/0day-ci/archive/20231103/202311030737.my9iglMI-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231103/202311030737.my9iglMI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311030737.my9iglMI-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/fork.c:52:
   include/linux/hugetlb.h: In function '__vma_private_lock':
>> include/linux/hugetlb.h:1276:17: error: implicit declaration of function 'is_vma_resv_set' [-Werror=implicit-function-declaration]
    1276 |                 is_vma_resv_set(vma, HPAGE_RESV_OWNER);
         |                 ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/is_vma_resv_set +1276 include/linux/hugetlb.h

  1271	
  1272	#define HPAGE_RESV_OWNER    (1UL << 0)
  1273	static inline bool __vma_private_lock(struct vm_area_struct *vma)
  1274	{
  1275		return (!(vma->vm_flags & VM_MAYSHARE)) && vma->vm_private_data && 
> 1276			is_vma_resv_set(vma, HPAGE_RESV_OWNER);
  1277	}
  1278	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki