linux-kernel - Re: [PATCH] net: usbnet: Fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231101213832.77bd657b@kernel.org>
Date:   Wed, 1 Nov 2023 21:38:32 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ren Mingshuai <renmingshuai@...wei.com>
Cc:     <caowangbao@...wei.com>, <davem@...emloft.net>,
        <khlebnikov@...nvz.org>, <liaichun@...wei.com>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <oneukum@...e.com>, <yanan@...wei.com>
Subject: Re: [PATCH] net: usbnet: Fix potential NULL pointer dereference

On Wed, 1 Nov 2023 20:55:11 +0800 Ren Mingshuai wrote:
> >23ba07991dad said SKB can be NULL without describing the triggering
> >scenario. Always Check it before dereference to void potential NULL
> >pointer dereference.  
> I've tried to find out the scenarios where SKB is NULL, but failed.
> It seems impossible for SKB to be NULL. If SKB can be NULL, please tell
> me the reason and I'd be very grateful.

What do you mean? Grepping the function name shows call sites with NULL
getting passed as skb.