linux-kernel - Re: [PATCH v5 09/14] x86/sev: Add Secure TSC support for SNP guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55de810b-66f9-49e3-8459-b7cac1532a0c@amd.com>
Date:   Thu, 2 Nov 2023 11:11:52 +0530
From:   "Nikunj A. Dadhania" <nikunj@....com>
To:     Tom Lendacky <thomas.lendacky@....com>,
        linux-kernel@...r.kernel.org, x86@...nel.org, kvm@...r.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     bp@...en8.de, mingo@...hat.com, tglx@...utronix.de,
        dave.hansen@...ux.intel.com, dionnaglaze@...gle.com,
        pgonda@...gle.com, seanjc@...gle.com, pbonzini@...hat.com
Subject: Re: [PATCH v5 09/14] x86/sev: Add Secure TSC support for SNP guests

On 10/31/2023 1:56 AM, Tom Lendacky wrote:
>> diff --git a/include/linux/cc_platform.h b/include/linux/cc_platform.h
>> index cb0d6cd1c12f..e081ca4d5da2 100644
>> --- a/include/linux/cc_platform.h
>> +++ b/include/linux/cc_platform.h
>> @@ -90,6 +90,14 @@ enum cc_attr {
>>        * Examples include TDX Guest.
>>        */
>>       CC_ATTR_HOTPLUG_DISABLED,
>> +
>> +    /**
>> +     * @CC_ATTR_GUEST_SECURE_TSC: Secure TSC is active.
>> +     *
>> +     * The platform/OS is running as a guest/virtual machine and actively
>> +     * using AMD SEV-SNP Secure TSC feature.
> 
> I think TDX also has a secure TSC like feature, so can this be generic?

Yes, we can do that. In SNP case SecureTSC is an optional feature, not sure if that is the case for TDX as well.

Kirill any inputs ?

> 
> Thanks,
> Tom
> 
>> +     */
>> +    CC_ATTR_GUEST_SECURE_TSC,
>>   };
>>     #ifdef CONFIG_ARCH_HAS_CC_PLATFORM 

Regards
Nikunj