linux-kernel - RE: [PATCH V4][1/4] mmc: solve DMA boundary limitation of CQHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee385d7d7de34e8f9203f2287b64f3b9@realtek.com>
Date:   Thu, 2 Nov 2023 08:00:36 +0000
From:   Jyan Chou [周芷安] <jyanchou@...ltek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "jh80.chung@...sung.com" <jh80.chung@...sung.com>,
        "riteshh@...eaurora.org" <riteshh@...eaurora.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "briannorris@...omium.org" <briannorris@...omium.org>,
        "doug@...morgal.com" <doug@...morgal.com>,
        "tonyhuang.sunplus@...il.com" <tonyhuang.sunplus@...il.com>,
        "abel.vesa@...aro.org" <abel.vesa@...aro.org>,
        "william.qiu@...rfivetech.com" <william.qiu@...rfivetech.com>
Subject: RE: [PATCH V4][1/4] mmc: solve DMA boundary limitation of CQHCI driver

>> Due to synopsys data book's description, it had a limitation while 
>> using DMA that buffer size and start address must not exceed 128 MB.
>>
>> We add an option setup_tran_desc to make tran_desc setting flexible.
>>
>> Signed-off-by: Jyan Chou <jyanchou@...ltek.com>
>>
>> ---
>> v2 -> v3:
>> - Fix auto test compile warning.
>>
>> v1 -> v2:
>> - Export cqhci_set_tran_desc for setting the descriptor's callback function.
>>
>> v0 -> v1:
>> - Separate different patch supports into single patch.
>> ---
>>  drivers/mmc/host/cqhci-core.c | 8 +++++++-
>>  drivers/mmc/host/cqhci.h      | 5 +++++
>>  2 files changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/cqhci-core.c 
>> b/drivers/mmc/host/cqhci-core.c index b3d7d6d8d654..5560329d2a7d 
>> 100644
>> --- a/drivers/mmc/host/cqhci-core.c
>> +++ b/drivers/mmc/host/cqhci-core.c
>> @@ -474,7 +474,7 @@ static int cqhci_dma_map(struct mmc_host *host, struct mmc_request *mrq)
>>       return sg_count;
>>  }
>>
>> -static void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, 
>> bool end,
>> +void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool 
>> +end,
>>                               bool dma64)  {
>>       __le32 *attr = (__le32 __force *)desc; @@ -495,6 +495,7 @@ 
>> static void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
>>               dataddr[0] = cpu_to_le32(addr);
>>       }
>>  }
>> +EXPORT_SYMBOL(cqhci_set_tran_desc);

> EXPORT_SYMBOL_GPL

We had corrected it.

Best regards,
Jyan

-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 
Sent: Monday, October 30, 2023 3:35 PM
To: Jyan Chou [周芷安] <jyanchou@...ltek.com>; ulf.hansson@...aro.org; adrian.hunter@...el.com; jh80.chung@...sung.com; riteshh@...eaurora.org; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org; asutoshd@...eaurora.org; p.zabel@...gutronix.de
Cc: linux-mmc@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; arnd@...db.de; briannorris@...omium.org; doug@...morgal.com; tonyhuang.sunplus@...il.com; abel.vesa@...aro.org; william.qiu@...rfivetech.com
Subject: Re: [PATCH V4][1/4] mmc: solve DMA boundary limitation of CQHCI driver


External mail.



On 30/10/2023 07:27, Jyan Chou wrote:
> Due to synopsys data book's description, it had a limitation while 
> using DMA that buffer size and start address must not exceed 128 MB.
>
> We add an option setup_tran_desc to make tran_desc setting flexible.
>
> Signed-off-by: Jyan Chou <jyanchou@...ltek.com>
>
> ---
> v2 -> v3:
> - Fix auto test compile warning.
>
> v1 -> v2:
> - Export cqhci_set_tran_desc for setting the descriptor's callback function.
>
> v0 -> v1:
> - Separate different patch supports into single patch.
> ---
> ---
>  drivers/mmc/host/cqhci-core.c | 8 +++++++-
>  drivers/mmc/host/cqhci.h      | 5 +++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci-core.c 
> b/drivers/mmc/host/cqhci-core.c index b3d7d6d8d654..5560329d2a7d 
> 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -474,7 +474,7 @@ static int cqhci_dma_map(struct mmc_host *host, struct mmc_request *mrq)
>       return sg_count;
>  }
>
> -static void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, 
> bool end,
> +void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool 
> +end,
>                               bool dma64)  {
>       __le32 *attr = (__le32 __force *)desc; @@ -495,6 +495,7 @@ 
> static void cqhci_set_tran_desc(u8 *desc, dma_addr_t addr, int len, bool end,
>               dataddr[0] = cpu_to_le32(addr);
>       }
>  }
> +EXPORT_SYMBOL(cqhci_set_tran_desc);

EXPORT_SYMBOL_GPL


Best regards,
Krzysztof