linux-kernel - Re: [PATCH v3] serial: 8250: 8250_omap: Clear UART_HAS_RHR_IT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbe705a6-dade-49ce-9ec8-6d7b87198d11@ti.com>
Date:   Thu, 2 Nov 2023 14:56:54 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Ronald Wahl <rwahl@....de>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ronald Wahl <ronald.wahl@...itan.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH v3] serial: 8250: 8250_omap: Clear UART_HAS_RHR_IT_DIS bit



On 31/10/23 16:39, Ronald Wahl wrote:
> From: Ronald Wahl <ronald.wahl@...itan.com>
> 
> This fixes commit 439c7183e5b9 ("serial: 8250: 8250_omap: Disable RX
> interrupt after DMA enable") which unfortunately set the
> UART_HAS_RHR_IT_DIS bit in the UART_OMAP_IER2 register and never
> cleared it.
> 
> Cc: stable@...r.kernel.org
> Fixes: 439c7183e5b9 ("serial: 8250: 8250_omap: Disable RX interrupt after DMA enable")
> Signed-off-by: Ronald Wahl <ronald.wahl@...itan.com>
> ---
> V3: - add Cc: stable@...r.kernel.org
> 
> V2: - add Fixes: tag
>     - fix author
> 
>  drivers/tty/serial/8250/8250_omap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index ca972fd37725..c7ab2963040b 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -914,7 +914,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
>  	if (priv->habit & UART_HAS_RHR_IT_DIS) {
>  		reg = serial_in(p, UART_OMAP_IER2);
>  		reg &= ~UART_OMAP_IER2_RHR_IT_DIS;
> -		serial_out(p, UART_OMAP_IER2, UART_OMAP_IER2_RHR_IT_DIS);
> +		serial_out(p, UART_OMAP_IER2, reg);
>  	}
> 
>  	dmaengine_tx_status(rxchan, cookie, &state);
> @@ -1060,7 +1060,7 @@ static int omap_8250_rx_dma(struct uart_8250_port *p)
>  	if (priv->habit & UART_HAS_RHR_IT_DIS) {
>  		reg = serial_in(p, UART_OMAP_IER2);
>  		reg |= UART_OMAP_IER2_RHR_IT_DIS;
> -		serial_out(p, UART_OMAP_IER2, UART_OMAP_IER2_RHR_IT_DIS);
> +		serial_out(p, UART_OMAP_IER2, reg);
>  	}
> 
>  	dma_async_issue_pending(dma->rxchan);


Thanks for the fix!

Reviewed-by: Vignesh Raghavendra <vigneshr@...com>



> --
> 2.41.0
> 

-- 
Regards
Vignesh