[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <496b78bb-ad12-4eed-a62c-8c2fd725ec61@redhat.com>
Date: Thu, 2 Nov 2023 12:03:39 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: "Huang, Kai" <kai.huang@...el.com>,
"Christopherson,, Sean" <seanjc@...gle.com>
Cc: "Li, Xiaoyao" <xiaoyao.li@...el.com>,
"kvm-riscv@...ts.infradead.org" <kvm-riscv@...ts.infradead.org>,
"mic@...ikod.net" <mic@...ikod.net>,
"liam.merwick@...cle.com" <liam.merwick@...cle.com>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"Yamahata, Isaku" <isaku.yamahata@...el.com>,
"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
"david@...hat.com" <david@...hat.com>,
"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
"amoorthy@...gle.com" <amoorthy@...gle.com>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"tabba@...gle.com" <tabba@...gle.com>,
"kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>,
"michael.roth@....com" <michael.roth@....com>,
"chao.p.peng@...ux.intel.com" <chao.p.peng@...ux.intel.com>,
"palmer@...belt.com" <palmer@...belt.com>,
"chenhuacai@...nel.org" <chenhuacai@...nel.org>,
"aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
"mpe@...erman.id.au" <mpe@...erman.id.au>,
"Annapurve, Vishal" <vannapurve@...gle.com>,
"vbabka@...e.cz" <vbabka@...e.cz>,
"mail@...iej.szmigiero.name" <mail@...iej.szmigiero.name>,
"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
"maz@...nel.org" <maz@...nel.org>,
"willy@...radead.org" <willy@...radead.org>,
"dmatlack@...gle.com" <dmatlack@...gle.com>,
"anup@...infault.org" <anup@...infault.org>,
"yu.c.zhang@...ux.intel.com" <yu.c.zhang@...ux.intel.com>,
"Xu, Yilun" <yilun.xu@...el.com>,
"qperret@...gle.com" <qperret@...gle.com>,
"brauner@...nel.org" <brauner@...nel.org>,
"isaku.yamahata@...il.com" <isaku.yamahata@...il.com>,
"ackerleytng@...gle.com" <ackerleytng@...gle.com>,
"jarkko@...nel.org" <jarkko@...nel.org>,
"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"Wang, Wei W" <wei.w.wang@...el.com>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [PATCH v13 09/35] KVM: Add KVM_EXIT_MEMORY_FAULT exit to report
faults to userspace
On 11/2/23 10:35, Huang, Kai wrote:
> IIUC KVM can already handle the case of poisoned
> page by sending signal to user app:
>
> static int kvm_handle_error_pfn(struct kvm_vcpu *vcpu,
> struct kvm_page_fault *fault)
> {
> ...
>
> if (fault->pfn == KVM_PFN_ERR_HWPOISON) {
> kvm_send_hwpoison_signal(fault->slot, fault->gfn);
> return RET_PF_RETRY;
> }
> }
EHWPOISON is not implemented by this series, so it should be left out of
the documentation.
> Currently as mentioned above when
> vepc fault handler cannot allocate EPC page KVM returns -EFAULT to Qemu, and
> Qemu prints ...
>
> ...: Bad address
> <dump guest cpu registers>
>
> ... which is nonsense.
>
> If we can use memory_fault.flags (or is 'fault_reason' a better name?) to carry
> a specific value for EPC to let Qemu know and Qemu can then do more reasonable
> things.
Yes, that's a good idea that can be implemented on top.
Paolo
Powered by blists - more mailing lists