linux-kernel - Re: [Patch v13 4/9] wifi: mac80211: Add support for WBRF features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b080757463a1f55a38484e3ea39fd3697e98409e.camel@sipsolutions.net>
Date:   Thu, 02 Nov 2023 13:04:52 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Ma Jun <Jun.Ma2@....com>
Cc:     amd-gfx@...ts.freedesktop.org, lenb@...nel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, alexander.deucher@....com, Lijo.Lazar@....com,
        mario.limonciello@....com, Netdev <netdev@...r.kernel.org>,
        linux-wireless@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, majun@....com,
        Evan Quan <quanliangl@...mail.com>
Subject: Re: [Patch v13 4/9] wifi: mac80211: Add support for WBRF features

On Thu, 2023-11-02 at 13:55 +0200, Ilpo Järvinen wrote:


[please trim your quotes]

> > +static void get_chan_freq_boundary(u32 center_freq, u32 bandwidth, u64 *start, u64 *end)
> > +{
> > +	bandwidth = MHZ_TO_KHZ(bandwidth);
> > +	center_freq = MHZ_TO_KHZ(center_freq);
> 
> Please use include/linux/units.h ones for these too.

Now we're feature creeping though - this has existed for *years* in the
wireless stack with many instances? We can convert them over, I guess,
but not sure that makes much sense here - we'd want to add such macros
to units.h, but ... moving them can be independent of this patch?

johannes