linux-kernel - Re: [PATCH v7 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZgqfzti8KW25m++VG2GhU7LZCgzxeWW+uaNO7rh1kmjg@mail.gmail.com>
Date:   Thu, 2 Nov 2023 13:49:09 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jim Liu <jim.t90615@...il.com>
Cc:     JJLIU0@...oton.com, krzysztof.kozlowski+dt@...aro.org,
        andy@...nel.org, benjaminfair@...gle.com, brgl@...ev.pl,
        robh@...nel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        openbmc@...ts.ozlabs.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v7 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver

Hi Jim,

thanks for your patch!

I saw that Andy already provided some good feedback but couldn't help
but to notice this:

On Wed, Nov 1, 2023 at 3:52 AM Jim Liu <jim.t90615@...il.com> wrote:

> Changes for v6:
>    - Remove bus-frequency property set
>    - Use GPIO_GENERIC
(...)
> +config GPIO_NPCM_SGPIO
> +       bool "Nuvoton SGPIO support"
> +       depends on (ARCH_NPCM || COMPILE_TEST) && OF_GPIO
> +       select GPIO_GENERIC

You select GPIO_GENERIC but you don't actually use it.
If you were using it, your code would be calling bgpio_init()
and it does not.

Yours,
Linus Walleij