[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABqG17h949R+3NFgA1MvPLZFc6zkBi+WRPSE9qP4fCBv5gdXHw@mail.gmail.com>
Date: Thu, 2 Nov 2023 20:17:35 +0530
From: Naresh Solanki <naresh.solanki@...ements.com>
To: Mark Brown <broonie@...nel.org>
Cc: zev@...ilderbeest.net, Liam Girdwood <lgirdwood@...il.com>,
Patrick Rudolph <patrick.rudolph@...ements.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/regulator: Notify sysfs about status changes
Hi Mark,
On Thu, 2 Nov 2023 at 18:36, Mark Brown <broonie@...nel.org> wrote:
>
> On Thu, Nov 02, 2023 at 05:35:42PM +0530, Naresh Solanki wrote:
> > On Thu, 5 Oct 2023 at 22:30, Mark Brown <broonie@...nel.org> wrote:
> > > On Thu, Oct 05, 2023 at 03:30:58PM +0200, Naresh Solanki wrote:
>
> > > We probably should filter the events more, there's events for pre and
> > > post voltage change for example which aren't status changes so would be
> > > spurious. It ought not to break anything but we should still avoid
> > > unneeded work.
>
> > Can you please provide me inputs on the additional filtering needed for this.
> > Like some list of events for notify on status?
>
> I think I'd start off with just reporting things that are obviously
> errors and not things that should ever go off during normal operation.
This is what I could come up with:
if (event & REGULATOR_EVENT_VOLTAGE_CHANGE) {
name = dev_attr_microvolts.attr.name;
sysfs_notify(&rdev->dev.kobj, NULL, name);
} else if (event & (REGULATOR_EVENT_DISABLE | REGULATOR_EVENT_ENABLE)){
name = dev_attr_status.attr.name;
sysfs_notify(&rdev->dev.kobj, NULL, name);
}
Regards,
Naresh
Powered by blists - more mailing lists