linux-kernel - Re: [PATCH bpf] selftests/bpf: Fix broken build where char is unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169893722400.13991.10009432921960035904.git-patchwork-notify@kernel.org>
Date:   Thu, 02 Nov 2023 15:00:24 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Björn Töpel <bjorn@...nel.org>@ci.codeaurora.org
Cc:     andrii@...nel.org, mykolal@...com, bpf@...r.kernel.org,
        daniel@...earbox.net, netdev@...r.kernel.org, bjorn@...osinc.com,
        ast@...nel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, larysa.zaremba@...el.com
Subject: Re: [PATCH bpf] selftests/bpf: Fix broken build where char is unsigned

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Thu,  2 Nov 2023 11:35:37 +0100 you wrote:
> From: Björn Töpel <bjorn@...osinc.com>
> 
> There are architectures where char is not signed. If so, the following
> error is triggered:
> 
>   | xdp_hw_metadata.c:435:42: error: result of comparison of constant -1 \
>   |   with expression of type 'char' is always true \
>   |   [-Werror,-Wtautological-constant-out-of-range-compare]
>   |   435 |         while ((opt = getopt(argc, argv, "mh")) != -1) {
>   |       |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
>   | 1 error generated.
> 
> [...]

Here is the summary with links:
  - [bpf] selftests/bpf: Fix broken build where char is unsigned
    https://git.kernel.org/bpf/bpf/c/d84b139f53e8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html