[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231102163728.GB20943@thinkpad>
Date: Thu, 2 Nov 2023 22:07:28 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: naomi.chu@...iatek.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Alim Akhtar <alim.akhtar@...sung.com>,
Avri Altman <avri.altman@....com>,
Bart Van Assche <bvanassche@....org>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Asutosh Das <quic_asutoshd@...cinc.com>,
Can Guo <quic_cang@...cinc.com>, wsd_upstream@...iatek.com,
peter.wang@...iatek.com, casper.li@...iatek.com,
powen.kao@...iatek.com, alice.chao@...iatek.com,
chun-hung.wu@...iatek.com, cc.chou@...iatek.com,
eddie.huang@...iatek.com
Subject: Re: [PATCH v3 1/1] ufs: core: Expand MCQ queue slot to
DeviceQueueDepth + 1
On Thu, Nov 02, 2023 at 01:24:24PM +0800, naomi.chu@...iatek.com wrote:
> From: Naomi Chu <naomi.chu@...iatek.com>
>
> The UFSHCI 4.0 specification mandates that there should always be at
> least one empty slot in each queue for distinguishing between full and
> empty states. Enlarge the `hwq->max_entries` to `DeviceQueueDepth +1`
> to allow UFSHCI 4.0 controllers to fully utilize MCQ queue slots.
>
> Fixes: 4682abfae2eb ("scsi: ufs: core: mcq: Allocate memory for MCQ mode")
> Signed-off-by: Naomi Chu <naomi.chu@...iatek.com>
> ---
Where is the changelog?
- Mani
> drivers/ufs/core/ufs-mcq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 2ba8ec254dce..5c75ab9d6bb5 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -436,7 +436,7 @@ int ufshcd_mcq_init(struct ufs_hba *hba)
>
> for (i = 0; i < hba->nr_hw_queues; i++) {
> hwq = &hba->uhq[i];
> - hwq->max_entries = hba->nutrs;
> + hwq->max_entries = hba->nutrs + 1;
> spin_lock_init(&hwq->sq_lock);
> spin_lock_init(&hwq->cq_lock);
> mutex_init(&hwq->sq_mutex);
> --
> 2.18.0
>
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists