linux-kernel - Re: [PATCH v8] rtc: tps6594: Add driver for TPS6594 RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5a18d7f-f327-48bb-8b64-cd53e74b4f04@kernel.org>
Date:   Fri, 3 Nov 2023 07:52:52 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Esteban Blanc <eblanc@...libre.com>, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com
Cc:     andy.shevchenko@...il.com, linux-kernel@...r.kernel.org,
        linux-rtc@...r.kernel.org, jpanis@...libre.com,
        jneanne@...libre.com, u-kumar1@...com
Subject: Re: [PATCH v8] rtc: tps6594: Add driver for TPS6594 RTC

On 02/11/2023 14:26, Esteban Blanc wrote:
> TPS6594 PMIC is a MFD. This patch adds support for
> the RTC found inside TPS6594 family of PMIC.
> 
> Alarm is also supported.
> 
> Signed-off-by: Esteban Blanc <eblanc@...libre.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> ---

...

> +
> +static struct platform_driver tps6594_rtc_driver = {
> +	.probe		= tps6594_rtc_probe,
> +	.driver		= {
> +		.name	= "tps6594-rtc",
> +	},
> +};
> +
> +module_platform_driver(tps6594_rtc_driver);
> +MODULE_ALIAS("platform:tps6594-rtc");

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.

This applies also to your other driver: pinctrl. Maybe to all your
drivers... Don't use MODULE_ALIAS() as substitute for missing tables.

Best regards,
Krzysztof