linux-kernel - Re: [RESEND PATCH] amd-pstate: Only print supported epp values for performance governor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZUTEnneqNcosb/1R@amd.com>
Date:   Fri, 3 Nov 2023 17:59:58 +0800
From:   Huang Rui <ray.huang@....com>
To:     "Jain, Ayush" <Ayush.Jain3@....com>
Cc:     "rafael@...nel.org" <rafael@...nel.org>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Karny, Wyes" <Wyes.Karny@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] amd-pstate: Only print supported epp values for
 performance governor

On Fri, Nov 03, 2023 at 05:48:15PM +0800, Jain, Ayush wrote:
> show_energy_performance_available_preferences() to show only supported
> values which is performance in performance governor policy.
> 
> -------Before--------
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_driver
> amd-pstate-epp
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_preference
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_available_preferences
> default performance balance_performance balance_power power
> 
> -------After--------
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_driver
> amd-pstate-epp
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_preference
> performance
> $ cat /sys/devices/system/cpu/cpu1/cpufreq/energy_performance_available_preferences
> performance
> 
> Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors")
> 
> Suggested-by: Wyes Karny <wyes.karny@....com>
> Signed-off-by: Ayush Jain <ayush.jain3@....com>
> Reviewed-by: Wyes Karny <wyes.karny@....com>

Nice catch, thanks for the fix.

Acked-by: Huang Rui <ray.huang@....com>

> 
> ---
>  drivers/cpufreq/amd-pstate.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9a1e194d5cf8..e6c5a57662e4 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -850,11 +850,16 @@ static ssize_t show_energy_performance_available_preferences(
>  {
>  	int i = 0;
>  	int offset = 0;
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE)
> +		return sysfs_emit_at(buf, offset, "%s\n",
> +				energy_perf_strings[EPP_INDEX_PERFORMANCE]);
>  
>  	while (energy_perf_strings[i] != NULL)
>  		offset += sysfs_emit_at(buf, offset, "%s ", energy_perf_strings[i++]);
>  
> -	sysfs_emit_at(buf, offset, "\n");
> +	offset += sysfs_emit_at(buf, offset, "\n");
>  
>  	return offset;
>  }
> -- 
> 2.34.1
>