linux-kernel - Re: [syzbot] test uaf in iommufd_vfio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000000000000e5d6a906093546db@google.com>
Date:   Thu, 02 Nov 2023 18:18:07 -0700
From:   syzbot <syzbot+d31adfb277377ef8fcba@...kaller.appspotmail.com>
To:     linux-kernel@...r.kernel.org
Subject: Re: [syzbot] test uaf in iommufd_vfio_ioas

For archival purposes, forwarding an incoming command email to
linux-kernel@...r.kernel.org.

***

Subject: test uaf in iommufd_vfio_ioas
Author: lizhi.xu@...driver.com

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2af9b20dbb39

diff --git a/drivers/iommu/iommufd/vfio_compat.c b/drivers/iommu/iommufd/vfio_compat.c
index 6c810bf80f99..85cff4489757 100644
--- a/drivers/iommu/iommufd/vfio_compat.c
+++ b/drivers/iommu/iommufd/vfio_compat.c
@@ -138,6 +138,8 @@ int iommufd_vfio_ioas(struct iommufd_ucmd *ucmd)
 
 	case IOMMU_VFIO_IOAS_SET:
 		ioas = iommufd_get_ioas(ucmd->ictx, cmd->ioas_id);
+		if (!ioas)
+			return -EINVAL;
 		if (IS_ERR(ioas))
 			return PTR_ERR(ioas);
 		xa_lock(&ucmd->ictx->objects);