linux-kernel - Re: [PATCH 4/5] fs/proc/page: use a folio in stable_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88a40128-e55a-4dde-b664-99ff3ead175b@huawei.com>
Date:   Fri, 3 Nov 2023 21:07:46 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>, <gourry.memverge@...il.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <linux-mm@...ck.org>, David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH 4/5] fs/proc/page: use a folio in stable_page_flags()



On 2023/11/3 20:28, Matthew Wilcox wrote:
> On Fri, Nov 03, 2023 at 03:29:05PM +0800, Kefeng Wang wrote:
>> Replace ten compound_head() calls with one page_folio().
> 
> This is going to conflict with Gregory Price's work:
> 
> https://lore.kernel.org/linux-mm/ZUCD1dsbrFjdZgVv@memverge.com/
> 
> Perhaps the two of you can collaborate on a patch series?

Will check this patch.

> 
>>   	u |= kpf_copy_bit(k, KPF_SLAB,		PG_slab);
>> -	if (PageTail(page) && PageSlab(page))
>> +	if (PageTail(page) && folio_test_slab(folio))
>>   		u |= 1 << KPF_SLAB;
> 
> This doesn't make sense ...
> 

Yes, after commit dcb351cd095a ("page-flags: define behavior SL*B-
related flags on compound pages"), the slab could not be a tail,
I will drop this line.