linux-kernel - Re: [PATCH] sound/isa/wavefront: copy userspace array safely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pm0rszup.wl-tiwai@suse.de>
Date:   Fri, 03 Nov 2023 14:58:22 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Philipp Stanner <pstanner@...hat.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Dave Airlie <airlied@...hat.com>
Subject: Re: [PATCH] sound/isa/wavefront: copy userspace array safely

On Thu, 02 Nov 2023 20:03:10 +0100,
Philipp Stanner wrote:
> 
> wavefront_fx.c utilizes memdup_user() to copy a userspace array. This
> does not check for an overflow.

There is a check above the memdup_user() call; it's at most 512
bytes.

> Use the new wrapper memdup_array_user() to copy the array more safely.
> 
> Suggested-by: Dave Airlie <airlied@...hat.com>
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

Although the check is already present, it's still better to use the
new helper, so I applied the patch now.


thanks,

Takashi