linux-kernel - Re: [PATCH v2] bus: mhi: host: Add alignment check for event ring read pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a04c7754-e807-9b5c-8565-e92ab513af94@quicinc.com>
Date:   Fri, 3 Nov 2023 08:54:47 -0600
From:   Jeffrey Hugo <quic_jhugo@...cinc.com>
To:     Krishna chaitanya chundru <quic_krichai@...cinc.com>,
        "Manivannan Sadhasivam" <mani@...nel.org>
CC:     <mhi@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_vbadigan@...cinc.com>,
        <quic_ramkri@...cinc.com>, <quic_skananth@...cinc.com>,
        <quic_parass@...cinc.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH v2] bus: mhi: host: Add alignment check for event ring
 read pointer

On 10/31/2023 3:51 AM, Krishna chaitanya chundru wrote:
> Though we do check the event ring read pointer by "is_valid_ring_ptr"
> to make sure it is in the buffer range, but there is another risk the
> pointer may be not aligned.  Since we are expecting event ring elements
> are 128 bits(struct mhi_ring_element) aligned, an unaligned read pointer
> could lead to multiple issues like DoS or ring buffer memory corruption.
> 
> So add a alignment check for event ring read pointer.
> 
> Fixes: ec32332df764 ("bus: mhi: core: Sanity check values from remote device before use")
> cc: stable@...r.kernel.org
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@...cinc.com>

Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>