[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ffb08cc2-705a-468e-b6d2-9ce591c08ab4@arm.com>
Date: Fri, 3 Nov 2023 15:34:54 +0000
From: Robin Murphy <robin.murphy@....com>
To: Duje Mihanović <duje.mihanovic@...le.hr>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Tony Lindgren <tony@...mide.com>,
Daniel Mack <daniel@...que.org>,
Haojian Zhuang <haojian.zhuang@...il.com>,
Robert Jarzmik <robert.jarzmik@...e.fr>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Leo Yan <leoy@...vell.com>,
Zhangfei Gao <zhangfei.gao@...vell.com>,
Lubomir Rintel <lkundrak@...sk>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Kees Cook <keescook@...omium.org>,
Tony Luck <tony.luck@...el.com>,
"Guilherme G . Piccoli" <gpiccoli@...lia.com>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
alsa-devel@...a-project.org, linux-hardening@...r.kernel.org,
phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
Karel Balej <balejk@...fyz.cz>
Subject: Re: [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell
PXA1908 platform
On 2023-11-02 3:20 pm, Duje Mihanović wrote:
> Add ARCH_MMP configuration option for Marvell PXA1908 SoC.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
> ---
> arch/arm64/Kconfig.platforms | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 6069120199bb..b417cae42c84 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -89,6 +89,17 @@ config ARCH_BERLIN
> help
> This enables support for Marvell Berlin SoC Family
>
> +config ARCH_MMP
> + bool "Marvell MMP SoC Family"
> + select ARM_GIC
> + select ARM_ARCH_TIMER
> + select ARM_SMMU
NAK, not only is selecting user-visible symbols generally frowned upon,
and ignoring their dependencies even worse, but for a multiplatform
kernel the user may well want this to be a module.
If having the SMMU driver built-in is somehow fundamentally required for
this platform to boot, that would represent much bigger problems.
Thanks,
Robin.
> + select MMP_PDMA
> + select PINCTRL_SINGLE
> + help
> + This enables support for Marvell MMP SoC family, currently
> + supporting PXA1908 aka IAP140.
> +
> config ARCH_BITMAIN
> bool "Bitmain SoC Platforms"
> help
Powered by blists - more mailing lists