linux-kernel - Re: [RFC 1/8] dt-bindings: usb: qcom,dwc3: Add bindings to enable runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0820464-16d6-47fd-90bc-cf80b5d76058@quicinc.com>
Date:   Fri, 3 Nov 2023 11:04:59 +0530
From:   Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To:     Caleb Connolly <caleb.connolly@...aro.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Bjorn Andersson <andersson@...nel.org>,
        "Konrad Dybcio" <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC:     <quic_wcheng@...cinc.com>, <linux-usb@...r.kernel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        "Philipp Zabel" <p.zabel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        <devicetree@...r.kernel.org>, <quic_ppratap@...cinc.com>,
        <quic_jackp@...cinc.com>
Subject: Re: [RFC 1/8] dt-bindings: usb: qcom,dwc3: Add bindings to enable
 runtime



On 11/3/2023 12:10 AM, Caleb Connolly wrote:
>> Hi Caleb,
>>
>>    There are two types of platforms, some use extcon and some use 
>> role-switch to deliver vbus/id notifications. Extcon targets already 
>> have this qscratch modifications present today in vbus and id 
>> handlers. But for role-switch based targets we don't have any way to 
>> get this notification to dwc3-qcom. In this implementation, I wanted 
>> to get those notications from core to glue and for this we implenented 
>> vendor hooks.
>>
>> The property added has been used to do two things:
>>
>> 1. Register glue's vendor hooks to core driver
>> 2. Do runtime_allow for glue (and by default for core as the dt is not 
>> flattened)
>>
>> In case of extcon, we don't want to register vendor hooks as 
>> notifications are not necessary.
> 
> Could it just be enabled when role_switch is present then?
>>

So we would register vendor hooks when usb-role-switch is present but 
don't do runtime allow, and leave that option to user space right ?
I think it would work and we can do away with the binding completely.

Will wait for comments from other folks as well on this approach.

Thanks for the review,
Krishna,