linux-kernel - Re: [PATCH v1] locking/atomic: xtensa: define arch_cmpxchg_local as __cmpxchg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMo8BfK4zDfdh9-WLq+gg1B47ht5hxhvH_j5veEj6JG38meTuw@mail.gmail.com>
Date:   Sat, 4 Nov 2023 02:31:42 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     "wuqiang.matt" <wuqiang.matt@...edance.com>
Cc:     chris@...kel.net, andi.shyti@...ux.intel.com,
        andrzej.hajda@...el.com, palmer@...osinc.com, geert@...ux-m68k.org,
        linux-kernel@...r.kernel.org, mattwu@....com
Subject: Re: [PATCH v1] locking/atomic: xtensa: define arch_cmpxchg_local as __cmpxchg_local

On Sat, Nov 4, 2023 at 2:06 AM wuqiang.matt <wuqiang.matt@...edance.com> wrote:
>
> The xtensa architecture already has __cmpxchg_local defined upon the
> native __cmpxchg_u32 and __generic_cmpxchg_local

This description does not make clear why this change is needed. Could you
please expand it to cover the 'why' part?

> Signed-off-by: wuqiang.matt <wuqiang.matt@...edance.com>
> ---
>  arch/xtensa/include/asm/cmpxchg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/xtensa/include/asm/cmpxchg.h b/arch/xtensa/include/asm/cmpxchg.h
> index 675a11ea8de7..956c9925df1c 100644
> --- a/arch/xtensa/include/asm/cmpxchg.h
> +++ b/arch/xtensa/include/asm/cmpxchg.h
> @@ -108,7 +108,7 @@ static inline unsigned long __cmpxchg_local(volatile void *ptr,
>   * them available.
>   */
>  #define arch_cmpxchg_local(ptr, o, n)                                         \
> -       ((__typeof__(*(ptr)))__generic_cmpxchg_local((ptr), (unsigned long)(o),\
> +       ((__typeof__(*(ptr)))__cmpxchg_local((ptr), (unsigned long)(o),        \
>                         (unsigned long)(n), sizeof(*(ptr))))
>  #define arch_cmpxchg64_local(ptr, o, n) __generic_cmpxchg64_local((ptr), (o), (n))
>  #define arch_cmpxchg64(ptr, o, n)    arch_cmpxchg64_local((ptr), (o), (n))
> --
> 2.40.1
>


-- 
Thanks.
-- Max