linux-kernel - Re: [PATCH] wifi: cfg80211: Fix use-after-free bug in brcmf_cfg80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Nov 2023 17:34:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zheng Wang <zyytlz.wz@....com>, aspriel@...il.com
Cc:     oe-kbuild-all@...ts.linux.dev, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, kvalo@...nel.org,
        johannes.berg@...el.com, marcan@...can.st,
        linus.walleij@...aro.org, jisoo.jang@...sei.ac.kr,
        linuxlovemin@...sei.ac.kr, wataru.gohda@...ress.com,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Zheng Wang <zyytlz.wz@....com>
Subject: Re: [PATCH] wifi: cfg80211: Fix use-after-free bug in
 brcmf_cfg80211_detach

Hi Zheng,

kernel test robot noticed the following build errors:

[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master v6.6 next-20231103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zheng-Wang/wifi-cfg80211-Fix-use-after-free-bug-in-brcmf_cfg80211_detach/20231104-135107
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20231104054709.716585-1-zyytlz.wz%40163.com
patch subject: [PATCH] wifi: cfg80211: Fix use-after-free bug in brcmf_cfg80211_detach
config: arc-randconfig-002-20231104 (https://download.01.org/0day-ci/archive/20231104/202311041735.pCIzwiLF-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311041735.pCIzwiLF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311041735.pCIzwiLF-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c: In function 'brcmf_cfg80211_detach':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:8436:34: error: passing argument 1 of 'cancel_delayed_work_sync' from incompatible pointer type [-Werror=incompatible-pointer-types]
    8436 |         cancel_delayed_work_sync(&cfg->escan_timeout_work);
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~
         |                                  |
         |                                  struct work_struct *
   In file included from include/linux/mm_types.h:19,
                    from include/linux/mmzone.h:22,
                    from include/linux/gfp.h:7,
                    from include/linux/xarray.h:15,
                    from include/linux/list_lru.h:14,
                    from include/linux/fs.h:13,
                    from include/linux/highmem.h:5,
                    from include/linux/bvec.h:10,
                    from include/linux/skbuff.h:17,
                    from include/linux/if_ether.h:19,
                    from include/linux/etherdevice.h:20,
                    from drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:9:
   include/linux/workqueue.h:511:59: note: expected 'struct delayed_work *' but argument is of type 'struct work_struct *'
     511 | extern bool cancel_delayed_work_sync(struct delayed_work *dwork);
         |                                      ~~~~~~~~~~~~~~~~~~~~~^~~~~
   cc1: some warnings being treated as errors


vim +/cancel_delayed_work_sync +8436 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

  8428	
  8429	void brcmf_cfg80211_detach(struct brcmf_cfg80211_info *cfg)
  8430	{
  8431		if (!cfg)
  8432			return;
  8433	
  8434		if (timer_pending(&cfg->escan_timeout))
  8435			del_timer_sync(&cfg->escan_timeout);
> 8436		cancel_delayed_work_sync(&cfg->escan_timeout_work);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki