linux-kernel - Re: [Patch v6 3/7] leds: ledtrig-tty: free allocated ttyname buffer on deactivate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6be2d8101fb8da3455974ead01721e7e@vanmierlo.com>
Date:   Sat, 04 Nov 2023 14:25:51 +0100
From:   m.brock@...mierlo.com
To:     Florian Eckert <fe@....tdt.de>
Cc:     Eckert.Florian@...glemail.com, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, pavel@....cz, lee@...nel.org,
        kabel@...nel.org, u.kleine-koenig@...gutronix.de,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [Patch v6 3/7] leds: ledtrig-tty: free allocated ttyname buffer
 on deactivate

Florian Eckert wrote on 2023-10-30 11:04:
> The ttyname buffer for the ledtrig_tty_data struct is allocated in the
> sysfs ttyname_store() function. This buffer must be released on trigger
> deactivation. This was missing and is thus a memory leak.

Shouldn´t there be a Fixes tag here?

And as a side note: you have patches 1..7/7 and a cover letter 0/8 ?

Maarten