linux-kernel - Re: [PATCH net-next] netfilter: nf_tables: Remove unused variable nft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231104163338.GN891380@kernel.org>
Date:   Sat, 4 Nov 2023 12:33:38 -0400
From:   Simon Horman <horms@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net,
        pabeni@...hat.com, fw@...len.de, kadlec@...filter.org,
        pablo@...filter.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH net-next] netfilter: nf_tables: Remove unused variable
 nft_net

On Wed, Nov 01, 2023 at 09:33:51AM +0800, Yang Li wrote:
> The code that uses nft_net has been removed, and the nft_pernet function
> is merely obtaining a reference to shared data through the net pointer.
> The content of the net pointer is not modified or changed, so both of
> them should be removed.
> 
> silence the warning:
> net/netfilter/nft_set_rbtree.c:627:26: warning: variable ‘nft_net’ set but not used
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7103
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

I think this is for nf-next, rather than net-next (which is closed).

But as for the change itself, I also noticed this, and am glad
to see it being addressed.

Reviewed-by: Simon Horman <horms@...nel.org>