linux-kernel - Re: [PATCH] net: ti: icssg-prueth: Add missing icss_iep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231104184331.GP891380@kernel.org>
Date:   Sat, 4 Nov 2023 14:43:31 -0400
From:   Simon Horman <horms@...nel.org>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        MD Danish Anwar <danishanwar@...com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@...mens.com>,
        Nishanth Menon <nm@...com>,
        "Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@...mens.com>
Subject: Re: [PATCH] net: ti: icssg-prueth: Add missing icss_iep_put to error
 path

On Thu, Nov 02, 2023 at 05:03:30PM +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@...mens.com>
> 
> Analogously to prueth_remove.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>

Hi Jan,

I am a little unclear if this patch addresses a user-visible bug, or
is adding a new feature.

If it is fixing a bug then it should be targeted at the net tree.
It should apply cleanly there, and the tree should be noted in the subject.

  Subject: [PATCH net] ...

Also, if it is a bug fix, it should have a fixes tag, indicating the
revision(s) where the problem was introduced. This to assist in backporting
fixes. In this case perhaps the following is appropriate:

On the other hand, if this is a new feature, then it should be targeted
at net-next:

  Subject: [PATCH net-next] ...

And in that case the following applies.

In either case, I think it would be good to expand the commit message.
It should explain why this change is being made.

## Form letter - net-next-closed

The merge window for v6.7 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after November 12th.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle

-- 
pw-bot: cr