linux-kernel - Re: [PATCH v1 1/4] leds: trigger: gpio: Replace custom code for gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaxvKwodyiXOYfOdyLYNzqKuVKPK3AtoC6HaRPdB4tLNA@mail.gmail.com>
Date:   Sat, 4 Nov 2023 23:26:06 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>
Subject: Re: [PATCH v1 1/4] leds: trigger: gpio: Replace custom code for gpiod_get_optional()

On Fri, Nov 3, 2023 at 8:53 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:

> gpiod_get_optional() and currently used fwnode_gpiod_get_index()
> are both wrappers against the same engine internally. Since we
> have a pointer to struct device there is no reason to use fwnode
> type of GPIO call. So, replace the current fwnode call by respective
> gpiod ones.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

I don't know what I was thinking here. Probably I was thinking that
the nodes doesn't always have a device, but hey, it does...
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij