linux-kernel - fs/ubifs/auth.c:30: warning: expecting prototype for ubifs_node_calc_hash(). Prototype was for __ubifs_node_calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 5 Nov 2023 21:31:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Richard Weinberger <richard@....at>
Subject: fs/ubifs/auth.c:30: warning: expecting prototype for
 ubifs_node_calc_hash(). Prototype was for __ubifs_node_calc_hash() instead

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1c41041124bd14dd6610da256a3da4e5b74ce6b1
commit: d8a22773a12c6d78ee758c9e530f3a488bb7cb29 ubifs: Enable authentication support
date:   5 years ago
config: x86_64-randconfig-012-20231101 (https://download.01.org/0day-ci/archive/20231105/202311052125.gE1Rylox-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311052125.gE1Rylox-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311052125.gE1Rylox-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/ubifs/auth.c:158:5: warning: no previous prototype for '__ubifs_shash_final' [-Wmissing-prototypes]
     158 | int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
         |     ^~~~~~~~~~~~~~~~~~~
>> fs/ubifs/auth.c:30: warning: expecting prototype for ubifs_node_calc_hash(). Prototype was for __ubifs_node_calc_hash() instead
   fs/ubifs/auth.c:80: warning: Function parameter or member 'inhash' not described in 'ubifs_prepare_auth_node'
   fs/ubifs/auth.c:80: warning: Excess function parameter 'hash' description in 'ubifs_prepare_auth_node'
   fs/ubifs/auth.o: warning: objtool: ubifs_init_authentication()+0x225: sibling call from callable instruction with modified stack frame


vim +30 fs/ubifs/auth.c

49525e5eecca5e Sascha Hauer 2018-09-07  19  
49525e5eecca5e Sascha Hauer 2018-09-07  20  /**
49525e5eecca5e Sascha Hauer 2018-09-07  21   * ubifs_node_calc_hash - calculate the hash of a UBIFS node
49525e5eecca5e Sascha Hauer 2018-09-07  22   * @c: UBIFS file-system description object
49525e5eecca5e Sascha Hauer 2018-09-07  23   * @node: the node to calculate a hash for
49525e5eecca5e Sascha Hauer 2018-09-07  24   * @hash: the returned hash
49525e5eecca5e Sascha Hauer 2018-09-07  25   *
49525e5eecca5e Sascha Hauer 2018-09-07  26   * Returns 0 for success or a negative error code otherwise.
49525e5eecca5e Sascha Hauer 2018-09-07  27   */
49525e5eecca5e Sascha Hauer 2018-09-07  28  int __ubifs_node_calc_hash(const struct ubifs_info *c, const void *node,
49525e5eecca5e Sascha Hauer 2018-09-07  29  			    u8 *hash)
49525e5eecca5e Sascha Hauer 2018-09-07 @30  {
49525e5eecca5e Sascha Hauer 2018-09-07  31  	const struct ubifs_ch *ch = node;
49525e5eecca5e Sascha Hauer 2018-09-07  32  	SHASH_DESC_ON_STACK(shash, c->hash_tfm);
49525e5eecca5e Sascha Hauer 2018-09-07  33  	int err;
49525e5eecca5e Sascha Hauer 2018-09-07  34  
49525e5eecca5e Sascha Hauer 2018-09-07  35  	shash->tfm = c->hash_tfm;
49525e5eecca5e Sascha Hauer 2018-09-07  36  	shash->flags = CRYPTO_TFM_REQ_MAY_SLEEP;
49525e5eecca5e Sascha Hauer 2018-09-07  37  
49525e5eecca5e Sascha Hauer 2018-09-07  38  	err = crypto_shash_digest(shash, node, le32_to_cpu(ch->len), hash);
49525e5eecca5e Sascha Hauer 2018-09-07  39  	if (err < 0)
49525e5eecca5e Sascha Hauer 2018-09-07  40  		return err;
49525e5eecca5e Sascha Hauer 2018-09-07  41  	return 0;
49525e5eecca5e Sascha Hauer 2018-09-07  42  }
49525e5eecca5e Sascha Hauer 2018-09-07  43  

:::::: The code at line 30 was first introduced by commit
:::::: 49525e5eecca5e1b4a83ac217868e8d8b843539f ubifs: Add helper functions for authentication support

:::::: TO: Sascha Hauer <s.hauer@...gutronix.de>
:::::: CC: Richard Weinberger <richard@....at>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki