linux-kernel - Re: [PATCH] selftests/nolibc: fix testcase status alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231105142659.GA21217@1wt.eu>
Date:   Sun, 5 Nov 2023 15:27:00 +0100
From:   Willy Tarreau <w@....eu>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/nolibc: fix testcase status alignment

On Sun, Nov 05, 2023 at 03:22:30PM +0100, Thomas Weißschuh wrote:
> Center-align all possible status reports.
> Before OK and FAIL were center-aligned in relation to each other but
> SKIPPED and FAILED would be left-aligned.
> 
> Before:
> 
> 7 environ_addr = <0x7fffef3e7c50>                                [OK]
> 8 environ_envp = <0x7fffef3e7c58>                               [FAIL]
> 9 environ_auxv                                                  [SKIPPED]
> 10 environ_total                                                [SKIPPED]
> 11 environ_HOME = <0x7fffef3e99bd>                               [OK]
> 12 auxv_addr                                                    [SKIPPED]
> 13 auxv_AT_UID = 1000                                            [OK]
> 
> After:
> 
> 7 environ_addr = <0x7ffff13b00a0>                                 [OK]
> 8 environ_envp = <0x7ffff13b00a8>                                [FAIL]
> 9 environ_auxv                                                  [SKIPPED]
> 10 environ_total                                                [SKIPPED]
> 11 environ_HOME = <0x7ffff13b19bd>                                [OK]
> 12 auxv_addr                                                    [SKIPPED]
> 13 auxv_AT_UID = 1000                                             [OK]
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Quite frankly for trivial cleanups like this you should not even bother
with sending a review, and could queue them directly!

Thanks,
Willy