lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 5 Nov 2023 11:48:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>
Subject: fs/vboxsf/vboxsf_wrappers.c:132: warning: Function parameter or
 member 'create_parms' not described in 'vboxsf_create'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   aea6bf908d730b01bd264a8821159db9463c111c
commit: 0fd169576648452725fa2949bf391d10883d3991 fs: Add VirtualBox guest shared folder (vboxsf) support
date:   3 years, 9 months ago
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20231105/202311051104.VxtpAuZ7-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231105/202311051104.VxtpAuZ7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311051104.VxtpAuZ7-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/vboxsf/vboxsf_wrappers.c:132: warning: Function parameter or member 'create_parms' not described in 'vboxsf_create'
>> fs/vboxsf/vboxsf_wrappers.c:132: warning: Excess function parameter 'param' description in 'vboxsf_create'


vim +132 fs/vboxsf/vboxsf_wrappers.c

   112	
   113	/**
   114	 * vboxsf_create - Create a new file or folder
   115	 * @root:         Root of the shared folder in which to create the file
   116	 * @parsed_path:  The path of the file or folder relative to the shared folder
   117	 * @param:        create_parms Parameters for file/folder creation.
   118	 *
   119	 * Create a new file or folder or open an existing one in a shared folder.
   120	 * Note this function always returns 0 / success unless an exceptional condition
   121	 * occurs - out of memory, invalid arguments, etc. If the file or folder could
   122	 * not be opened or created, create_parms->handle will be set to
   123	 * SHFL_HANDLE_NIL on return.  In this case the value in create_parms->result
   124	 * provides information as to why (e.g. SHFL_FILE_EXISTS), create_parms->result
   125	 * is also set on success as additional information.
   126	 *
   127	 * Returns:
   128	 * 0 or negative errno value.
   129	 */
   130	int vboxsf_create(u32 root, struct shfl_string *parsed_path,
   131			  struct shfl_createparms *create_parms)
 > 132	{
   133		struct shfl_create parms;
   134	
   135		parms.root.type = VMMDEV_HGCM_PARM_TYPE_32BIT;
   136		parms.root.u.value32 = root;
   137	
   138		parms.path.type = VMMDEV_HGCM_PARM_TYPE_LINADDR_KERNEL;
   139		parms.path.u.pointer.size = shfl_string_buf_size(parsed_path);
   140		parms.path.u.pointer.u.linear_addr = (uintptr_t)parsed_path;
   141	
   142		parms.parms.type = VMMDEV_HGCM_PARM_TYPE_LINADDR_KERNEL;
   143		parms.parms.u.pointer.size = sizeof(struct shfl_createparms);
   144		parms.parms.u.pointer.u.linear_addr = (uintptr_t)create_parms;
   145	
   146		return vboxsf_call(SHFL_FN_CREATE, &parms, SHFL_CPARMS_CREATE, NULL);
   147	}
   148	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists