linux-kernel - Re: [PATCH] kbuild: deb-pkg: apply short --rules-file option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQE=ankopXh_6q=Rw+JA+MVus5jjyuS3YBoJVz4YPDB1A@mail.gmail.com>
Date:   Sun, 5 Nov 2023 17:08:19 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Dmitrii Bundin <dmitrii.bundin.a@...il.com>
Cc:     linux-kbuild@...r.kernel.org, nathan@...nel.org,
        ndesaulniers@...gle.com, nicolas@...sle.eu,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: deb-pkg: apply short --rules-file option

On Sat, Nov 4, 2023 at 8:43 AM Dmitrii Bundin
<dmitrii.bundin.a@...il.com> wrote:
>
> The long --rules-file option might not be available for some older
> versions of dpkg-buildpackage resulting in build failures. The -R option
> has been available since 1.14.17 allowing builds for larger allowing
> builds for larger set of versions of dpkg-buildpackage.
>
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
> ---
>  scripts/Makefile.package | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index 2bcab02da965..0afbf5ad2919 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -148,7 +148,7 @@ deb-pkg srcdeb-pkg bindeb-pkg:
>         $(if $(findstring source, $(build-type)), \
>                 --unsigned-source --compression=$(KDEB_SOURCE_COMPRESS)) \
>         $(if $(findstring binary, $(build-type)), \
> -               --rules-file='$(MAKE) -f debian/rules' --jobs=1 -r$(KBUILD_PKG_ROOTCMD) -a$$(cat debian/arch), \
> +               -R'$(MAKE) -f debian/rules' --jobs=1 -r$(KBUILD_PKG_ROOTCMD) -a$$(cat debian/arch), \
>                 --no-check-builddeps) \
>         $(DPKG_FLAGS))
>
> --
> 2.17.1
>


The replacement is inconsistent because you replaced
--rule-file, but kept --jobs, both of which are available
since 1.18.8



-j, --jobs[=jobs|auto]
   Specifies  the  number  of  jobs  allowed  to be run simultaneously
   (since dpkg 1.14.7, long option since dpkg 1.18.8).

-R, --rules-file=rules‐file
   Building  a  Debian package usually involves invoking debian/rules
   as a command with several standard parameters (since dpkg 1.14.17,
   long option since dpkg 1.18.8).


I do not think it is a big deal because the version 1.18.8
was released in 2016.




-- 
Best Regards
Masahiro Yamada