linux-kernel - RE: [PATCH v2 12/13] scsi: fnic: Add support for multiqueue (MQ) in fnic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58968181F46112B8C7B5CA36C3AAA@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date:   Mon, 6 Nov 2023 20:25:37 +0000
From:   "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To:     Hannes Reinecke <hare@...e.de>,
        "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>
CC:     "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>,
        "Dhanraj Jhawar (djhawar)" <djhawar@...co.com>,
        "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>,
        "Masa Kai (mkai2)" <mkai2@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 12/13] scsi: fnic: Add support for multiqueue (MQ) in
 fnic driver

On Thursday, November 2, 2023 1:12 AM, Hannes Reinecke <hare@...e.de> wrote:
>
> On 10/27/23 20:03, Karan Tilak Kumar wrote:
> >
> That is odd.
> If you pass in 'mqtag' you can derive the hardware queue from it, so you don't need to pass it in separately.
> Alternative it would make sense to pass in the 'tag' value instead of 'mqtag', as this would simplify the code (seeint that you don't have to call blk_mq_unique_tag_to_tag() all over the place).
>
> Cheers,
> Hannes
>
>

The former approach sounds better.
I'll adopt it in v3.

Regards,
Karan