linux-kernel - Re: [PATCH v4 3/3] drm/panel-edp: Avoid adding multiple preferred modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2023 13:12:23 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Hsin-Yi Wang <hsinyi@...omium.org>
Cc:     Neil Armstrong <neil.armstrong@...aro.org>,
        Jessica Zhang <quic_jesszhan@...cinc.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] drm/panel-edp: Avoid adding multiple preferred modes

Hi,

On Mon, Nov 6, 2023 at 1:03 PM Hsin-Yi Wang <hsinyi@...omium.org> wrote:
>
> @@ -622,7 +627,7 @@ static int panel_edp_get_modes(struct drm_panel *panel,
>          * and no modes (the generic edp-panel case) because it will clobber
>          * the display_info that was already set by drm_add_edid_modes().
>          */
> -       if (p->desc->num_timings || p->desc->num_modes)
> +       if (has_hard_coded_modes)

nit: the comment above this line is a bit confusing now and probably
needs to be updated or removed.