lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADnq5_PXRN+PL4wp+sWOXs2L5nQiRmfrw4065R1TE4YKw-ZeUA@mail.gmail.com>
Date:   Mon, 6 Nov 2023 16:37:14 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Abhinav Singh <singhabhinav9051571833@...il.com>
Cc:     alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

On Mon, Nov 6, 2023 at 4:20 PM Abhinav Singh
<singhabhinav9051571833@...il.com> wrote:
>
> On 11/7/23 00:25, Alex Deucher wrote:
> > Applied.  This matches what we already do in the other clear state headers.
> >
> > Alex
> >
> > On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh
> > <singhabhinav9051571833@...il.com> wrote:
> >>
> >> sparse static analysis tools generate a warning with this message
> >> "Using plain integer as NULL pointer". In this case this warning is
> >> being shown because we are trying to intialize a pointer to NULL using
> >> integer value 0.
> >>
> >> Signed-off-by: Abhinav Singh <singhabhinav9051571833@...il.com>
> >> ---
> >>   drivers/gpu/drm/radeon/clearstate_evergreen.h | 8 ++++----
> >>   1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/radeon/clearstate_evergreen.h b/drivers/gpu/drm/radeon/clearstate_evergreen.h
> >> index 63a1ffbb3ced..3b645558f133 100644
> >> --- a/drivers/gpu/drm/radeon/clearstate_evergreen.h
> >> +++ b/drivers/gpu/drm/radeon/clearstate_evergreen.h
> >> @@ -1049,7 +1049,7 @@ static const struct cs_extent_def SECT_CONTEXT_defs[] =
> >>       {SECT_CONTEXT_def_5, 0x0000a29e, 5 },
> >>       {SECT_CONTEXT_def_6, 0x0000a2a5, 56 },
> >>       {SECT_CONTEXT_def_7, 0x0000a2de, 290 },
> >> -    { 0, 0, 0 }
> >> +    { NULL, 0, 0 }
> >>   };
> >>   static const u32 SECT_CLEAR_def_1[] =
> >>   {
> >> @@ -1060,7 +1060,7 @@ static const u32 SECT_CLEAR_def_1[] =
> >>   static const struct cs_extent_def SECT_CLEAR_defs[] =
> >>   {
> >>       {SECT_CLEAR_def_1, 0x0000ffc0, 3 },
> >> -    { 0, 0, 0 }
> >> +    { NULL, 0, 0 }
> >>   };
> >>   static const u32 SECT_CTRLCONST_def_1[] =
> >>   {
> >> @@ -1070,11 +1070,11 @@ static const u32 SECT_CTRLCONST_def_1[] =
> >>   static const struct cs_extent_def SECT_CTRLCONST_defs[] =
> >>   {
> >>       {SECT_CTRLCONST_def_1, 0x0000f3fc, 2 },
> >> -    { 0, 0, 0 }
> >> +    { NULL, 0, 0 }
> >>   };
> >>   static const struct cs_section_def evergreen_cs_data[] = {
> >>       { SECT_CONTEXT_defs, SECT_CONTEXT },
> >>       { SECT_CLEAR_defs, SECT_CLEAR },
> >>       { SECT_CTRLCONST_defs, SECT_CTRLCONST },
> >> -    { 0, SECT_NONE }
> >> +    { NULL, SECT_NONE }
> >>   };
> >> --
> >> 2.39.2
> >>
> Hi Alex, thanks for looking into this. By applied you mean this patch is
> accepted and it has been merged?

Yes.  Once it makes it through our CI system, it will show up in my
drm-next tree.

Alex

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ