linux-kernel - drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: sparse: sparse: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2023 09:23:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: sparse: sparse:
 symbol 'apple_pmgr_reset_ops' was not declared. Should it be static?

Hi Ulf,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   77fa2fbe87fc605c4bfa87dff87be9bfded0e9a3
commit: e2ad626f8f409899baf1bf192d0533a851128b19 pmdomain: Rename the genpd subsystem to pmdomain
date:   8 weeks ago
config: arm64-randconfig-r122-20231102 (https://download.01.org/0day-ci/archive/20231106/202311060916.WwbD4jNN-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231106/202311060916.WwbD4jNN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311060916.WwbD4jNN-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: sparse: sparse: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static?

vim +/apple_pmgr_reset_ops +180 drivers/pmdomain/apple/pmgr-pwrstate.c

6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24  179  
6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24 @180  const struct reset_control_ops apple_pmgr_reset_ops = {
6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24  181  	.assert		= apple_pmgr_reset_assert,
6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24  182  	.deassert	= apple_pmgr_reset_deassert,
6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24  183  	.reset		= apple_pmgr_reset_reset,
6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24  184  	.status		= apple_pmgr_reset_status,
6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24  185  };
6df9d38f9146e8 drivers/soc/apple/apple-pmgr-pwrstate.c Hector Martin 2021-11-24  186  

:::::: The code at line 180 was first introduced by commit
:::::: 6df9d38f9146e83b473f0c9e57fb5fdf3fcc93e2 soc: apple: Add driver for Apple PMGR power state controls

:::::: TO: Hector Martin <marcan@...can.st>
:::::: CC: Hector Martin <marcan@...can.st>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki