linux-kernel - RE: [PATCH V2 5/6] mmc: cqhci: Warn of halt or task clear failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB6575B4B1FD9565A3DC5B7DF1FCAAA@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Mon, 6 Nov 2023 07:38:32 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Kornel Dulęba <korneld@...omium.org>,
        Radoslaw Biernacki <biernacki@...gle.com>,
        Gwendal Grignou <gwendal@...omium.org>,
        Asutosh Das <quic_asutoshd@...cinc.com>
CC:     Chaotian Jing <chaotian.jing@...iatek.com>,
        Bhavya Kapoor <b-kapoor@...com>,
        Kamal Dasu <kamal.dasu@...adcom.com>,
        Al Cooper <alcooperx@...il.com>,
        Haibo Chen <haibo.chen@....com>,
        Shaik Sajida Bhanu <quic_c_sbhanu@...cinc.com>,
        Sai Krishna Potthuri <sai.krishna.potthuri@....com>,
        Victor Shih <victor.shih@...esyslogic.com.tw>,
        Ben Chuang <ben.chuang@...esyslogic.com.tw>,
        Thierry Reding <thierry.reding@...il.com>,
        Aniruddha Tvs Rao <anrao@...dia.com>,
        Chun-Hung Wu <chun-hung.wu@...iatek.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2 5/6] mmc: cqhci: Warn of halt or task clear failure

> A correctly operating controller should successfully halt and clear tasks.
> Failure may result in errors elsewhere, so promote messages from debug to
> warnings.
> 
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled
> host")
> Cc: stable@...r.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
Reviewed-by: Avri Altman <avri.altman@....com>

> ---
>  drivers/mmc/host/cqhci-core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index 15f5a069af1f..948799a0980c 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -942,8 +942,8 @@ static bool cqhci_clear_all_tasks(struct mmc_host
> *mmc, unsigned int timeout)
>         ret = cqhci_tasks_cleared(cq_host);
> 
>         if (!ret)
> -               pr_debug("%s: cqhci: Failed to clear tasks\n",
> -                        mmc_hostname(mmc));
> +               pr_warn("%s: cqhci: Failed to clear tasks\n",
> +                       mmc_hostname(mmc));
> 
>         return ret;
>  }
> @@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *mmc,
> unsigned int timeout)
>         ret = cqhci_halted(cq_host);
> 
>         if (!ret)
> -               pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
> +               pr_warn("%s: cqhci: Failed to halt\n",
> + mmc_hostname(mmc));
> 
>         return ret;
>  }
> --
> 2.34.1