linux-kernel - Re: [PATCH] nbd: fix uaf in nbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae7a6b56-14c6-02e6-6e4b-572c23178049@huaweicloud.com>
Date:   Mon, 6 Nov 2023 20:44:41 +0800
From:   Li Lingfeng <lilingfeng@...weicloud.com>
To:     Christoph Hellwig <hch@....de>
Cc:     josef@...icpanda.com, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org, nbd@...er.debian.org, axboe@...nel.dk,
        chaitanya.kulkarni@....com, yukuai1@...weicloud.com,
        houtao1@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com,
        lilingfeng3@...wei.com
Subject: Re: [PATCH] nbd: fix uaf in nbd_open


在 2023/11/3 16:12, Christoph Hellwig 写道:
> On Fri, Nov 03, 2023 at 06:13:34PM +0800, Li Lingfeng wrote:
>> From: Li Lingfeng <lilingfeng3@...wei.com>
>>
>> Commit 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and
>> blk_cleanup_disk") cleans up disk by blk_cleanup_disk() and it won't set
>> disk->private_data as NULL as before. UAF may be triggered in nbd_open()
>> if someone tries to open nbd device right after nbd_put() since refcount
>> of nbd device is zero and private_data is not NULL.
> I don't think this is the right fix.  nbd needs to move to ->free_disk
> to free it's private data.
Thanks for your advice, I will send v2 soon.