[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231106144914.bflq2jxejdxs6zjb@pengutronix.de>
Date: Mon, 6 Nov 2023 15:49:14 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Florian Eckert <fe@....tdt.de>
Cc: Eckert.Florian@...glemail.com, pavel@....cz, lee@...nel.org,
kabel@...nel.org, gregkh@...uxfoundation.org,
linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
stable@...r.kernel.org
Subject: Re: [Patch v2] leds: ledtrig-tty: free allocated ttyname buffer on
deactivate
On Mon, Nov 06, 2023 at 03:12:05PM +0100, Florian Eckert wrote:
> The ttyname buffer for the ledtrig_tty_data struct is allocated in the
> sysfs ttyname_store() function. This buffer must be released on trigger
> deactivation. This was missing and is thus a memory leak.
>
> While we are at it, the tty handler in the ledtrig_tty_data struct should
> also be returned in case of the trigger deactivation call.
>
> Cc: stable@...r.kernel.org
> Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
> Signed-off-by: Florian Eckert <fe@....tdt.de>
I already provided that to v1, but my reply and the v2 crossed, so I'm
forwarding my tag to this v2:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists