linux-kernel - Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c2fb6c7-c7c8-b607-c160-df27000a37b1@quicinc.com>
Date:   Mon, 6 Nov 2023 20:21:53 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Komal Bajaj <quic_kbajaj@...cinc.com>
CC:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_nainmeht@...cinc.com>
Subject: Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and
 rb3 board



On 11/6/2023 6:35 PM, Krzysztof Kozlowski wrote:
> On 06/11/2023 12:41, Mukesh Ojha wrote:
> 
>>> I agree here. What exactly is common in the real hardware between IDP
>>> and RB3? Commit msg does not explain it, so I do not see enough
>>> justification for common file. Just because some DTS looks similar for
>>> different hardware does not mean you should creat common file.
>>
>> @Dmitry/@...ysztof,
>>
>> Thank you for reviewing the RFC, we wanted to continue the
>> suggestion/discussion given on [1] , where we discussed that this
>> qcm6490 is going to be targeted for IOT segment and will have different
>> memory map and it is going to use some of co-processors like adsp/cdsp
>> which chrome does not use.
>>
>> So to your question what is common between RB3 and IDP, mostly they will
>> share common memory map(similar to [2]) and regulator settings and both
> 
> The question was what is common hardware, not common in your DTS.

Got your point.
Let me know if you agree with the suggestion shared here

https://lore.kernel.org/lkml/CAA8EJpq89g9EeyKcogU+Mt9ie6Bk-rmgi=GqyycYBm_291i1Bw@mail.gmail.com/

-Mukesh
> 
> 
>> will use adsp/cdsp etc., we will be posting the memory map changes as
>> well in coming weeks once this RFC is acked.
> 
> Sorry, that's not common part of hardware.
> 
> Best regards,
> Krzysztof
>