linux-kernel - RE: [PATCH] USB: xhci-plat: fix legacy PHY double inity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <848aad6777f54fa88ebd4277642853aa@realtek.com>
Date:   Mon, 6 Nov 2023 03:48:37 +0000
From:   Stanley Chang[昌育德] <stanley_chang@...ltek.com>
To:     Stefan Eichenberger <eichest@...il.com>,
        Johan Hovold <johan+linaro@...nel.org>
CC:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Maxime Ripard <mripard@...nel.org>
Subject: RE: [PATCH] USB: xhci-plat: fix legacy PHY double inity


> On Fri, Nov 03, 2023 at 05:43:23PM +0100, Johan Hovold wrote:
> > Commits 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") and
> > 9134c1fd0503 ("usb: xhci: plat: Add USB 3.0 phy support") added
> > support for looking up legacy PHYs from the sysdev devicetree node and
> > initialising them.
> >
> > This broke drivers such as dwc3 which manages PHYs themself as the
> > PHYs would now be initialised twice, something which specifically can
> > lead to resources being left enabled during suspend (e.g. with the
> > usb_phy_generic PHY driver).
> >
> > As the dwc3 driver uses driver-name matching for the xhci platform
> > device, fix this by only looking up and initialising PHYs for devices
> > that have been matched using OF.
> >
> > Note that checking that the platform device has a devicetree node
> > would currently be sufficient, but that could lead to subtle breakages
> > in case anyone ever tries to reuse an ancestor's node.
> >
> > Fixes: 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support")
> > Fixes: 9134c1fd0503 ("usb: xhci: plat: Add USB 3.0 phy support")
> > Cc: stable@...r.kernel.org      # 4.1
> > Cc: Maxime Ripard <mripard@...nel.org>
> > Cc: Stanley Chang <stanley_chang@...ltek.com>
> > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> 
> Tested-by: Stefan Eichenberger <stefan.eichenberger@...adex.com>

Tested-by: Stanley Chang <stanley_chang@...ltek.com>