linux-kernel - Re: [PATCH] bpf: Use E2BIG instead of ENOENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <21a93447-6830-4884-b488-cbac38df1b96@gmail.com>
Date:   Tue, 7 Nov 2023 00:13:06 +0800
From:   Tao Chen <chen.dylane@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Song Liu <song@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Yonghong Song <yonghong.song@...ux.dev>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        John Fastabend <john.fastabend@...il.com>,
        Hao Luo <haoluo@...gle.com>, bpf <bpf@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT


Hi, Alexei, the delete element api of stackmap return E2BIG when the key 
size beyond the buckets size, so i try to keep the same approach. Maybe 
it's not necessary, anyway, thanks for your reply.

在 2023/11/6 下午11:59, Tao Chen 写道:
> 
> 
> ---------- Forwarded message ---------
> 发件人： *Alexei Starovoitov* <alexei.starovoitov@...il.com 
> <mailto:alexei.starovoitov@...il.com>>
> Date: 2023年11月5日周日 04:54
> Subject: Re: [PATCH] bpf: Use E2BIG instead of ENOENT
> To: Tao Chen <chen.dylane@...il.com <mailto:chen.dylane@...il.com>>
> Cc: Song Liu <song@...nel.org <mailto:song@...nel.org>>, Jiri Olsa 
> <jolsa@...nel.org <mailto:jolsa@...nel.org>>, Alexei Starovoitov 
> <ast@...nel.org <mailto:ast@...nel.org>>, Daniel Borkmann 
> <daniel@...earbox.net <mailto:daniel@...earbox.net>>, Andrii Nakryiko 
> <andrii@...nel.org <mailto:andrii@...nel.org>>, Yonghong Song 
> <yonghong.song@...ux.dev <mailto:yonghong.song@...ux.dev>>, Martin KaFai 
> Lau <martin.lau@...ux.dev <mailto:martin.lau@...ux.dev>>, John Fastabend 
> <john.fastabend@...il.com <mailto:john.fastabend@...il.com>>, Hao Luo 
> <haoluo@...gle.com <mailto:haoluo@...gle.com>>, bpf <bpf@...r.kernel.org 
> <mailto:bpf@...r.kernel.org>>, LKML <linux-kernel@...r.kernel.org 
> <mailto:linux-kernel@...r.kernel.org>>
> 
> 
> On Fri, Nov 3, 2023 at 7:44 PM Tao Chen <chen.dylane@...il.com 
> <mailto:chen.dylane@...il.com>> wrote:
>  >
>  > Use E2BIG instead of ENOENT when the key size beyond the buckets size,
>  > it seems more meaningful.
> 
> seems more meaningful?
> Sorry. That's hardly a reason to break someone's code.