linux-kernel - Re: [PATCH] HID:i2c-hid:goodix:Modify post_power_delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UKA1sRMppdzmdX-48Hu7OKL=nWURS79kxTAJpu3Dq5PQ@mail.gmail.com>
Date:   Mon, 6 Nov 2023 08:40:18 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     xiazhengqiao <xiazhengqiao@...qin.corp-partner.google.com>
Cc:     jikos@...nel.org, benjamin.tissoires@...hat.com, mka@...omium.org,
        fshao@...omium.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        xuxinxiong@...qin.corp-partner.google.com
Subject: Re: [PATCH] HID:i2c-hid:goodix:Modify post_power_delay_ms to avoid
 touchscreen not working

Hi,

On Sat, Nov 4, 2023 at 11:36 PM xiazhengqiao
<xiazhengqiao@...qin.corp-partner.google.com> wrote:
>
> For "goodix,gt7375p" touchscreen, When the device restarts,
> the reset pin of the touchscreen will be pulled down by 10ms,
> but this time will make the touchscreen have a probability of
> not working properly. Increase post_power_delay_ms to 20ms,
> so that the reset pin is pulled down 20ms, and toucsreen works fine.

s/toucsreen/touchscreen


> Signed-off-by: xiazhengqiao <xiazhengqiao@...qin.corp-partner.google.com>
> ---
>  drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> index f1597ad67e7c..caabf7a62cde 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> @@ -111,7 +111,7 @@ static int i2c_hid_of_goodix_probe(struct i2c_client *client)
>  }
>
>  static const struct goodix_i2c_hid_timing_data goodix_gt7375p_timing_data = {
> -       .post_power_delay_ms = 10,
> +       .post_power_delay_ms = 20,

Do you actually have a Goodix "GT7375P" touchscreen, or do you have
some other touchscreen that is using the Goodix GT7375P compatible
string? As far as I know the 10 ms here came from the Goodix GT7375P
datasheet and has been working fine with devices that have Goodix
GT7373P. Has this always been wrong for the Goodix GT7373P, or (as I
suspect) do you actually have a different touchscreen and for that
different touchscreen you need a longer delay?

-Doug