linux-kernel - Re: [RESEND PATCH] dt-bindings: crypto: qcom,prng: Add SM8450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2b73ea0-c659-431e-9275-88d1a98f37cf@quicinc.com>
Date:   Mon, 6 Nov 2023 09:05:36 -0800
From:   Elliot Berman <quic_eberman@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Vinod Koul <vkoul@...nel.org>
CC:     Conor Dooley <conor.dooley@...rochip.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] dt-bindings: crypto: qcom,prng: Add SM8450



On 11/5/2023 5:03 AM, Krzysztof Kozlowski wrote:
> On 03/11/2023 23:52, Elliot Berman wrote:
>> From: Konrad Dybcio <konrad.dybcio@...aro.org>
>>
>> SM8450's PRNG does not require a core clock reference. Add a new
>> compatible with a qcom,prng-ee fallback and handle that.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
>> Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
>> ---
>> I noticed this patch got missed while running make dtbs_check. No
>> changes to this patch from the original version:
>>
>> https://lore.kernel.org/all/2c208796-5ad6-c362-dabc-1228b978ca1d@linaro.org/
>>
> 
> I don't understand why do you send this. This is not a correct patch,
> was rejected. Different patch was already merged.

I see that 6.6 has

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm8450.dtsi?h=v6.6#n1741

but bindings not updated:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/crypto/qcom,prng.yaml?h=v6.6

I came up with similar-ish fix offline, then found Konrad had posted the patch when searching lore.
I didn't find any other patch on lore. 

I think you rejected a proposal to drop "p" from "prng", but this patch
doesn't do that and we stayed course with naming scheme.

Thanks,

Elliot