linux-kernel - Re: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0l2hkw6.ffs@tglx>
Date:   Mon, 06 Nov 2023 18:06:01 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     James Tai <james.tai@...ltek.com>, linux-kernel@...r.kernel.org,
        linux-realtek-soc@...ts.infradead.org
Cc:     Marc Zyngier <maz@...nel.org>
Subject: Re: [PATCH 3/6] irqchip: Introduce RTD1319 support using the
 Realtek Common Interrupt Controller Driver

On Thu, Nov 02 2023 at 22:27, James Tai wrote:
> +
> +enum rtd1319_iso_isr_bits {
> +	RTD1319_ISO_ISR_TC3_SHIFT = 1,
> +	RTD1319_ISO_ISR_UR0_SHIFT = 2,

Please use tabular formatting all over the place.

> +	RTD1319_ISO_ISR_LSADC0_SHIFT = 3,
> +	RTD1319_ISO_ISR_IRDA_SHIFT = 5,
> +


> +static const struct realtek_intc_info rtd1319_intc_iso_info = {
> +	.isr_offset = 0x0,
> +	.umsk_isr_offset = 0x4,
> +	.scpu_int_en_offset = 0x40,

Magic numbers. Defines exist for a reason.