[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFJe6O1oJnQvLVSJZP6MMXULGrX=a3SEO1X5b4xff06WhqLw_g@mail.gmail.com>
Date: Mon, 6 Nov 2023 13:32:11 -0500
From: Hunter Chasens <hunter.chasens18@....edu>
To: Jani Nikula <jani.nikula@...el.com>
Cc: Bagas Sanjaya <bagasdotme@...il.com>, corbet@....net,
Luca Coelho <luciano.coelho@...el.com>, airlied@...il.com,
daniel@...ll.ch, maarten.lankhorst@...ux.intel.com,
mripard@...nel.org, tzimmermann@...e.de,
dri-devel@...ts.freedesktop.org,
Linux Documentation <linux-doc@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused
directives for namespacing
When running `make htmldocs` the following warnings are given.
```
Documentation/gpu/rfc/i915_scheduler.rst:138: WARNING:
Unknown directive type "c:namespace-push".
.. c:namespace-push:: rfc
Documentation/gpu/rfc/i915_scheduler.rst:143: WARNING:
Unknown directive type "c:namespace-pop".
.. c:namespace-pop::
```
The kernel test robot also reported it here.
Link: https://lore.kernel.org/all/202311061623.86pTQrie-lkp@intel.com/
Last year Maryam Tahhan <mtahhan@...hat.com> from Redhat noticed something
similar. "The missing support of c:namespace-push:: and c:namespace-pop::
directives by helper scripts for kernel documentation prevents using the
``c:function::`` directive with proper namespacing." From the context, it
sounds like this was brought about from a Sphinx update.
Link: https://lore.kernel.org/all/20221123092321.88558-3-mtahhan@redhat.com/
When compiled the `.. kernel-doc::` literal gives it the same formatting with
or without the namespace directives present. Due to the above information I
think it safe to remove these, as they don't seem to do anything but
throw warnings.
On Mon, Nov 6, 2023 at 5:31 AM Jani Nikula <jani.nikula@...el.com> wrote:
>
> On Mon, 06 Nov 2023, Bagas Sanjaya <bagasdotme@...il.com> wrote:
> > On Sat, Nov 04, 2023 at 09:47:08AM -0400, Hunter Chasens wrote:
> >> diff --git a/Documentation/gpu/rfc/i915_scheduler.rst b/Documentation/gpu/rfc/i915_scheduler.rst
> >> index c237ebc024cd..23ba7006929b 100644
> >> --- a/Documentation/gpu/rfc/i915_scheduler.rst
> >> +++ b/Documentation/gpu/rfc/i915_scheduler.rst
> >> @@ -135,13 +135,9 @@ Add I915_CONTEXT_ENGINES_EXT_PARALLEL_SUBMIT and
> >> drm_i915_context_engines_parallel_submit to the uAPI to implement this
> >> extension.
> >>
> >> -.. c:namespace-push:: rfc
> >> -
> >> .. kernel-doc:: include/uapi/drm/i915_drm.h
> >> :functions: i915_context_engines_parallel_submit
> >>
> >> -.. c:namespace-pop::
> >> -
>
> What makes the namespacing unnecessary?
>
> $ git grep '.. kernel-doc:: include/uapi/drm/i915_drm.h'
> Documentation/gpu/driver-uapi.rst:.. kernel-doc:: include/uapi/drm/i915_drm.h
> Documentation/gpu/rfc/i915_scheduler.rst:.. kernel-doc:: include/uapi/drm/i915_drm.h
>
> And you get [1] and [2].
>
> >> Extend execbuf2 IOCTL to support submitting N BBs in a single IOCTL
> >> -------------------------------------------------------------------
> >> Contexts that have been configured with the 'set_parallel' extension can only
> >
> > The warnings go away, thanks!
>
> What warnings go away?
>
> BR,
> Jani.
>
>
> [1] https://docs.kernel.org/gpu/driver-uapi.html#c.i915_context_engines_parallel_submit
> [2] https://docs.kernel.org/gpu/rfc/i915_scheduler.html#c.rfc.i915_context_engines_parallel_submit
>
> >
> > Fixes: f6757dfcfde7 ("drm/doc: fix duplicate declaration warning")
> > Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>
>
> --
> Jani Nikula, Intel
Powered by blists - more mailing lists