linux-kernel - Re: [PATCH] drm/amd/display: avoid variable reinitialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_OS+15+u-4w3Ca9Q+ivm8U1P=6r-pOrC9fCbZSAUR=5hA@mail.gmail.com>
Date:   Mon, 6 Nov 2023 13:35:37 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Bragatheswaran Manickavel <bragathemanick0908@...il.com>
Cc:     harry.wentland@....com, sunpeng.li@....com,
        Rodrigo.Siqueira@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, daniel@...ll.ch,
        airlied@...il.com, Qingqing.Zhuo@....com, alvin.lee2@....com,
        wenjing.liu@....com, jun.lei@....com, Samson.Tam@....com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: avoid variable reinitialization

Applied.  Thanks!

On Tue, Oct 24, 2023 at 2:11 PM Bragatheswaran Manickavel
<bragathemanick0908@...il.com> wrote:
>
> The member variable enable_hpo_pg_support is already initialized
> and hence the reinitialization instruction can be removed. Issue
> identified using the doubleinit.cocci Coccinelle semantic patch script.
>
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@...il.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> index 99d55b958977..1fd9df8da09c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_resource.c
> @@ -739,7 +739,6 @@ static const struct dc_debug_options debug_defaults_drv = {
>         .disable_boot_optimizations = false,
>         .disable_unbounded_requesting = false,
>         .disable_mem_low_power = false,
> -       .enable_hpo_pg_support = false,
>         //must match enable_single_display_2to1_odm_policy to support dynamic ODM transitions
>         .enable_double_buffered_dsc_pg_support = true,
>         .enable_dp_dig_pixel_rate_div_policy = 1,
> --
> 2.34.1
>