linux-kernel - Re: [PATCH v1 2/2] hwmon: (pmbus) Add support for MPS Multi-phase mp5990

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7506203-8633-4b94-aa66-ebab4436f300@roeck-us.net>
Date:   Mon, 6 Nov 2023 11:11:47 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     PeterYin <peteryin.openbmc@...il.com>, patrick@...cx.xyz,
        Jean Delvare <jdelvare@...e.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v1 2/2] hwmon: (pmbus) Add support for MPS Multi-phase
 mp5990

On 11/6/23 00:02, PeterYin wrote:
> 
[ ... ]
>>> +
>>> +static const struct of_device_id mp5990_of_match[] = {
>>> +    { .compatible = "mps,mp5990" },
>>> +    {}
>>> +};
>>> +
>>> +static const struct i2c_device_id mp5990_id[] = {
>>> +    {"mp5990", 0},
>>> +    { }
>>> +};
>>> +MODULE_DEVICE_TABLE(i2c, mp5990_id);
>>> +
>>> +static struct i2c_driver mp5990_driver = {
>>> +    .driver = {
>>> +           .name = "mp5990",
>>> +           .of_match_table = of_match_ptr(mp5990_of_match),
>>
>> Using of_match_ptr() will result in a build failure if CONFIG_OF=n.
>>
> Should I use .of_match_table = mp5990_of_match, ?
> 

Yes.

Thanks,
Guenter