linux-kernel - Re: [PATCH] drm/amd/display: clean up redundant conversions to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_NpMmo5SdXdStcRMGfcz0v6Nu-ZTORsSHo4_m_piAB77Q@mail.gmail.com>
Date:   Tue, 7 Nov 2023 10:39:40 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     José Pekkarinen <jose.pekkarinen@...hound.fi>
Cc:     harry.wentland@....com, sunpeng.li@....com,
        Rodrigo.Siqueira@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com,
        skhan@...uxfoundation.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        Bhawanpreet.Lakha@....com, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] drm/amd/display: clean up redundant conversions to bool

On Tue, Nov 7, 2023 at 4:44 AM José Pekkarinen
<jose.pekkarinen@...hound.fi> wrote:
>
> This patch will address the following couple of warnings retrieved by
> using coccinelle, where there is an explicit conversion to bool that
> are redundant.
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:94:102-107: WARNING: conversion to bool not needed here
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:102:72-77: WARNING: conversion to bool not needed here
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@...hound.fi>

Thanks for the patch, but this was already fixed by Srinivasan a while ago.

Alex

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
> index 32d3086c4cb7..5ce542b1f860 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
> @@ -91,7 +91,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac
>         pr_config.replay_supported = true;
>         pr_config.replay_power_opt_supported = 0;
>         pr_config.replay_enable_option |= pr_enable_option_static_screen;
> -       pr_config.replay_timing_sync_supported = aconnector->max_vfreq >= 2 * aconnector->min_vfreq ? true : false;
> +       pr_config.replay_timing_sync_supported = aconnector->max_vfreq >= 2 * aconnector->min_vfreq;
>
>         if (!pr_config.replay_timing_sync_supported)
>                 pr_config.replay_enable_option &= ~pr_enable_option_general_ui;
> @@ -99,7 +99,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac
>         debug_flags = (union replay_debug_flags *)&pr_config.debug_flags;
>         debug_flags->u32All = 0;
>         debug_flags->bitfields.visual_confirm =
> -               link->ctx->dc->debug.visual_confirm == VISUAL_CONFIRM_REPLAY ? true : false;
> +               link->ctx->dc->debug.visual_confirm == VISUAL_CONFIRM_REPLAY;
>
>         link->replay_settings.replay_feature_enabled = true;
>
> --
> 2.39.2
>